RuleGroups.Validate(...) needs unexported struct ruleGroups as input

[sylr]

I'm trying to upgrade prometheus dep in thanos and I'm stuck with this:

$ make build
all modules verified
>> building binaries /Users/s.rabot/go/bin
 >   thanos
# github.com/thanos-io/thanos/cmd/thanos
cmd/thanos/check.go:88:29: not enough arguments in call to promRgs.Validate
	have ()
	want (rulefmt.ruleGroups)

prometheus/pkg/rulefmt/rulefmt.go

Line 66 in 51c8245

func (g *RuleGroups) Validate(node ruleGroups) (errs []error) {

cc @bwplotka

[bwplotka]

Why you put issue on Prometheus for this? It's normal we will have build errors to fix. We plan to upgrade deps after chunk iterator.

[sylr]

Because I thought there was little that could be done in thanos if prometheus does not export ruleGroups or adds a NewruleGroups() ruleGroups func.

Am I mistaken ?

[aclowkey]

I think it should be exported for non-thanos related reasons.
For example if I want to build a tool that manages alerts, and not implement my own validation logic, I can't.

I could do something like this:

_, errs := rulefmt.Parse([]byte(definition)

Then errs would have elements of type rulefmt.Error which have WrappedError that has needed context, but all of it's fields are unexported..

[brian-brazil]

Use of our internals by 3rd parties is unsupported, but we will generally accept PRs to make things public.

[bwplotka]

Let's move forward with this then... (:

It's blocking thanos-io/thanos#2535

[bwplotka]

Are you still happy to continue this @sylr

[sylr]

@bwplotka I wish I could but I am pretty busy at the moment.

[roidelapluie]

Actually the way forward is to get back to yaml.v2 as there are missing features in yaml.v3

[bwplotka]

Do you have any details / related discussion @roidelapluie ?

[sylr]

#7142 (comment)

[roidelapluie]

Actually things are moving now.. I will see that later on.

[roidelapluie]

cmd/thanos/check.go > I do not see that file in thanos codebase?

[bwplotka]

It just changed - it is now in cmd/thanos/tools.go

…

On Wed, 6 May 2020 at 00:33, Julien Pivotto ***@***.***> wrote: cmd/thanos/check.go > I do not see that file in thanos codebase? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7128 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVA3O7VQP5GAKVQKAADTALRQCO6NANCNFSM4MI5NU3A> .