Refactor/major simplifications and test behaviors and sundry #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change includes implementation of most major storage layer features, albeit some imperfect. It also includes nascent telemetry bindings, too.
ghost
assigned 
| @@ -45,6 +46,10 @@ type Metric map[LabelName]LabelValue | |||
| // remedied down the road. | |||
| type SampleValue float32 | |||
|
|
|||
| func (s SampleValue) String() string { | |||
| return fmt.Sprintf("%f", s) | |||
There was a problem hiding this comment.
Do we actually need this for something? For humans, showing 1 as "1" and not "1.000000" seems to be nicer. %v does the right thing already unless you always want the full precision displayed.
juliusv
added a commit
that referenced
this pull request
Jan 4, 2013
…and-test-behaviors-and-sundry Refactor/major simplifications and test behaviors and sundry
juliusv
added a commit
that referenced
this pull request
Jan 15, 2013
…and-test-behaviors-and-sundry Refactor/major simplifications and test behaviors and sundry
matttproud
added a commit
that referenced
this pull request
Apr 9, 2014
Change Humanize() -> String()
matttproud
added a commit
that referenced
this pull request
Apr 9, 2014
Change Humanize() -> String()
juliusv
added a commit
that referenced
this pull request
Apr 9, 2014
…onse-delegate Include Daniel's ResponseWriter delegate type.
juliusv
pushed a commit
that referenced
this pull request
Jul 3, 2016
Add a consistent-hashing distribution service.
This was referenced Sep 9, 2016
Closed
simonpasquier
referenced
this pull request
in simonpasquier/prometheus
Oct 12, 2017
make some spacing changes to the main page
cofyc
added a commit
to cofyc/prometheus
that referenced
this pull request
Jan 29, 2018
Add kirk release scripts.
hectorj2f
pushed a commit
to hectorj2f/prometheus
that referenced
this pull request
Apr 27, 2018
Add prometheus data source automatically
bwplotka
pushed a commit
that referenced
this pull request
Jul 16, 2020
Created a tool to import data formatted according to the Prometheus exposition format. The tool can be accessed via the TSDB CLI. Addresses #535 Signed-off-by: Dipack P Panjabi <dipack.panjabi@gmail.com> Update PR to comply with changes on master. Signed-off-by: Dipack P Panjabi <dipack.panjabi@gmail.com> Add Importer tool minimal documentation (#1) * Add Importer tool minimal documentation * Reduce a little import file example Update docs. Courtesy of @gillg Signed-off-by: Dipack P Panjabi <dipack.panjabi@gmail.com>
bwplotka
pushed a commit
that referenced
this pull request
Jul 16, 2020
Created a tool to import data formatted according to the Prometheus exposition format. The tool can be accessed via the TSDB CLI. Addresses #535 Signed-off-by: Dipack P Panjabi <dipack.panjabi@gmail.com> Update PR to comply with changes on master. Signed-off-by: Dipack P Panjabi <dipack.panjabi@gmail.com> Add Importer tool minimal documentation (#1) * Add Importer tool minimal documentation * Reduce a little import file example Update docs. Courtesy of @gillg Signed-off-by: Dipack P Panjabi <dipack.panjabi@gmail.com> Fix stuff because of rebase Signed-off-by: Dipack P Panjabi <dipack.panjabi@gmail.com>
bwplotka
pushed a commit
that referenced
this pull request
Jul 16, 2020
Created a tool to import data formatted according to the Prometheus exposition format. The tool can be accessed via the TSDB CLI. Addresses #535 Signed-off-by: Dipack P Panjabi <dipack.panjabi@gmail.com> Update PR to comply with changes on master. Signed-off-by: Dipack P Panjabi <dipack.panjabi@gmail.com> Add Importer tool minimal documentation (#1) * Add Importer tool minimal documentation * Reduce a little import file example Update docs. Courtesy of @gillg Signed-off-by: Dipack P Panjabi <dipack.panjabi@gmail.com> Fix stuff because of rebase Signed-off-by: Dipack P Panjabi <dipack.panjabi@gmail.com>
roidelapluie
referenced
this pull request
in roidelapluie/prometheus
Mar 9, 2021
Multiple improvements
Smithx10
pushed a commit
to Smithx10/prometheus
that referenced
this pull request
Feb 8, 2022
Dieterbe
pushed a commit
to Dieterbe/prometheus
that referenced
this pull request
Feb 19, 2022
* Added sharding support to Querier.Select() Signed-off-by: Marco Pracucci <marco@pracucci.com> * Addressed review comments Signed-off-by: Marco Pracucci <marco@pracucci.com>
aserhat
pushed a commit
to aserhat/prometheus
that referenced
this pull request
Jul 14, 2023
Merge in ~E778046/oss-fork-prometheus-prometheus from feature/metrics_explorer_page to oss-contribution-approval * commit '0faaf47ebd5f17d718071e561e5a4120b72d9211': Created a dedicated tab for metrics explorer
cstyan
pushed a commit
that referenced
this pull request
Nov 7, 2023
gotjosh
added a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: gotjosh <josue.abreu@gmail.com>
gotjosh
added a commit
that referenced
this pull request
May 16, 2024
Signed-off-by: gotjosh <josue.abreu@gmail.com>
gotjosh
added a commit
that referenced
this pull request
May 30, 2024
* [PATCH] Allow having evaluation delay for rule groups Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * [PATCH] Fix lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * [PATCH] Move the option to ManagerOptions Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * [PATCH] Include evaluation_delay in the group config Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix comments Signed-off-by: gotjosh <josue.abreu@gmail.com> * Add a server configuration option. Signed-off-by: gotjosh <josue.abreu@gmail.com> * Appease the linter #1 Signed-off-by: gotjosh <josue.abreu@gmail.com> * Add the new server flag documentation Signed-off-by: gotjosh <josue.abreu@gmail.com> * Improve documentation of the new flag and configuration Signed-off-by: gotjosh <josue.abreu@gmail.com> * Use named parameters for clarity on the `Rule` interface Signed-off-by: gotjosh <josue.abreu@gmail.com> * Add `initial` to the flag help Signed-off-by: gotjosh <josue.abreu@gmail.com> * Change the CHANGELOG area from `ruler` to `rules` Signed-off-by: gotjosh <josue.abreu@gmail.com> * Rename evaluation_delay to `rule_query_offset`/`query_offset` and make it a global configuration option. Signed-off-by: gotjosh <josue.abreu@gmail.com> E Your branch is up to date with 'origin/gotjosh/evaluation-delay'. * more docs Signed-off-by: gotjosh <josue.abreu@gmail.com> * Improve wording on CHANGELOG Signed-off-by: gotjosh <josue.abreu@gmail.com> * Add `RuleQueryOffset` to the default config in tests in case it changes Signed-off-by: gotjosh <josue.abreu@gmail.com> * Update docs/configuration/recording_rules.md Co-authored-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: gotjosh <josue.abreu@gmail.com> * Rename `RuleQueryOffset` to `QueryOffset` when in the group context. Signed-off-by: gotjosh <josue.abreu@gmail.com> * Improve docstring and documentation on the `rule_query_offset` Signed-off-by: gotjosh <josue.abreu@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Signed-off-by: gotjosh <josue.abreu@gmail.com> Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: Julius Volz <julius.volz@gmail.com>
saswatamcode
pushed a commit
to saswatamcode/prometheus
that referenced
this pull request
Jun 17, 2024
add prow file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.