Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow go mod versioning rules and update the module name #10353

Closed
wants to merge 1 commit into from
Closed

Follow go mod versioning rules and update the module name #10353

wants to merge 1 commit into from

Conversation

vihangm
Copy link

@vihangm vihangm commented Feb 24, 2022

The reason this package doesn't include releases after v2.5.0+incompatible on pkg.go.dev is that the go.mod file was added between v2.5.0 and v.2.6.0 but the module name wasn't compatible with go module semver rules.

This updates the module name. This ensures that go get github.com/prometheus/prometheus will fetch v1.8.2 but
go get github.com/prometheus/prometheus/v2 will fetch v2.33.4

See https://research.swtch.com/vgo-import and https://go.dev/blog/v2-go-modules for more info.

Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>
@tomwilkie
Copy link
Member

Theres an active discussion on this topic going on on #8852 and I don't think we're reached a consensus yet on what we'd like to do. I suggest you chip in there, and lets get this topic added to the dev summit next week to discuss.

@vihangm vihangm marked this pull request as draft February 25, 2022 14:59
@vihangm
Copy link
Author

vihangm commented Feb 26, 2022

Whoops, sorry for the noise. I tried searching through the issues but didn't find that one. Thanks for the pointer. Closing this and will wait for resolution on the current discussion.

@vihangm vihangm closed this Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants