Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discovery managers to be properly cancelled #10569

Merged
merged 1 commit into from Sep 29, 2023

Conversation

zzJinux
Copy link
Contributor

@zzJinux zzJinux commented Apr 8, 2022

for range m.ctx.Done() won't let the program touch its body; m.ctx.Done() will only close.

Although I don't know what m.cancelDiscoverers exaclty does, it seems to me that it must be called for graceful shutdown.

Here is the simple demo for comparing: https://go.dev/play/p/UDzf26J0zcs

@roidelapluie

Signed-off-by: Jinwook Jeong <vustthat@gmail.com>
@zzJinux
Copy link
Contributor Author

zzJinux commented Apr 11, 2022

I don't have idea why three of those checks fail. It seems temporary network connection issue I guess?

@roidelapluie
Copy link
Member

Thanks, I will test this later

@roidelapluie roidelapluie self-assigned this Jul 18, 2023
@roidelapluie roidelapluie merged commit 4b735f0 into prometheus:main Sep 29, 2023
@roidelapluie
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants