uber.go/automaxprocs package upgrade for cgroups2 support #10584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll rebase as soon as fix for ui test is in main. 🙂 |
|
@Nexucis this ui tests seem to be flappy. do you know why? |
|
Could you change base branch to release-2.35? we are cutting a new rc anyway |
TomasKohout
force-pushed
the
automaxprocs_upgrade
branch
from
0e6776d
to
f861663
Compare
TomasKohout
force-pushed
the
automaxprocs_upgrade
branch
2 times, most recently
from
cda5e74
to
db81f01
Compare
roidelapluie
approved these changes
Apr 13, 2022
|
Can you cherry pick only your commit? |
Signed-off-by: Tomas Kohout <tomas.kohout1995@gmail.com>
TomasKohout
force-pushed
the
automaxprocs_upgrade
branch
from
db81f01
to
5fadd5c
Compare
|
Done. 👍 |
Not yet :/. Another weird things with the UI environment. You fixed one thing, another one doesn't work as expected lol. |
Nexucis
approved these changes
Apr 13, 2022
roidelapluie
pushed a commit
to roidelapluie/prometheus
that referenced
this pull request
Jun 22, 2022
…#10584) Signed-off-by: Tomas Kohout <tomas.kohout1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomas Kohout tomas.kohout1995@gmail.com
Hi,
I'm here only to bump version of automaxprocs to 1.5.1 since it now supports v2 cgroups. 🙂