feat: add linode SD failure count metric #10673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @roidelapluie for when you get time! |
|
LGTM, can you please fix linting? |
|
My bad! Should've let CI runs complete before pinging you, sorry about that. I'll fix it! |
This commit introduces a new metric to count the number of failed requests to Linode's API when using Linode SD. Resolves prometheus#10672, inspired by prometheus#10476. _Note_: this doens't count failures when polling the `/account/events` endpoint, as a `401` there is how we determine if the supplied token has the needed API scopes to do event polling vs full refreshes each interval. Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
tjhop
force-pushed
the
feat/linode-sd-failure-metric
branch
from
9fab601
to
4caaad7
Compare
|
TIL about local package prefixes for Looking better now, @roidelapluie! |
roidelapluie
approved these changes
May 11, 2022
|
Thanks! |
roidelapluie
pushed a commit
to roidelapluie/prometheus
that referenced
this pull request
Jun 22, 2022
This commit introduces a new metric to count the number of failed requests to Linode's API when using Linode SD. Resolves prometheus#10672, inspired by prometheus#10476. _Note_: this doens't count failures when polling the `/account/events` endpoint, as a `401` there is how we determine if the supplied token has the needed API scopes to do event polling vs full refreshes each interval. Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new metric to count the number of failed
requests to Linode's API when using Linode SD. Resolves #10672, inspired
by #10476.
Note: this doens't count failures when polling the
/account/eventsendpoint, as a
401there is how we determine if the supplied token hasthe needed API scopes to do event polling vs full refreshes each
interval.
Signed-off-by: TJ Hoplock t.hoplock@gmail.com