Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable ui module publication #10876

Merged
merged 4 commits into from
Jun 30, 2022
Merged

Conversation

Nexucis
Copy link
Member

@Nexucis Nexucis commented Jun 16, 2022

This PR is here to (re) enable the publication of the package codemirror-promql and lezer-promql under the new npm org prometheus-io

Following the last news on the CI/CD of Prometheus, I choose to create a new github action to do it. Hope it's fine like that.

I choose to publish the libs under the tag v0.XX.YY to follow the same thought around the Prometheus Go module.

Signed-off-by: Augustin Husson husson.augustin@gmail.com

@Nexucis Nexucis requested a review from juliusv as a code owner June 16, 2022 09:49
@Nexucis Nexucis force-pushed the nexucis/reanable-codemirror-publication branch 3 times, most recently from 884106b to 8148128 Compare June 16, 2022 10:00
@Nexucis
Copy link
Member Author

Nexucis commented Jun 16, 2022

For the release procedure, I'm still unsure what to do regarding the changelog. Should we use the Changelog of Prometheus or use and keep a specific changelog for codemirror-promql / lezer-promql.

@Nexucis Nexucis force-pushed the nexucis/reanable-codemirror-publication branch from 8148128 to d758528 Compare June 16, 2022 10:08
@Nexucis
Copy link
Member Author

Nexucis commented Jun 16, 2022

once this PR is ok and merged, we will be able to archive the repositories prometheus/lezer-promql and prometheus/codemirror-promql

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis force-pushed the nexucis/reanable-codemirror-publication branch from d758528 to 182adfd Compare June 16, 2022 10:18
RELEASE.md Outdated Show resolved Hide resolved
@juliusv
Copy link
Member

juliusv commented Jun 16, 2022

Would be good if someone a little more familiar with the GitHub actions build stuff like maybe @roidelapluie could have a brief look as well.

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis
Copy link
Member Author

Nexucis commented Jun 16, 2022

I had a quick talked with @juliusv regarding the change and the packaging of the lib, and we think we can start by using the Prometheus changelog to reflect the changes in the libs.

To reflect this thought, I have removed the old changelog of codemirror-promql and updated the script in charge of releasing the UI to copy the changelog at the root of the project in the libs.

Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis
Copy link
Member Author

Nexucis commented Jun 17, 2022

I added the NPM token in the secrets. We are ready to publish the packages in the prometheus-io organization.

@roidelapluie
Copy link
Member

Can we merge this @juliusv ?

@juliusv
Copy link
Member

juliusv commented Jun 30, 2022

👍 Yep, looks fine to me as far as I understand it, assuming you are good with it then too :)

@juliusv juliusv merged commit 7b006e8 into main Jun 30, 2022
@juliusv juliusv deleted the nexucis/reanable-codemirror-publication branch June 30, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants