Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize exemplar record type in WAL watcher metrics #11008

Merged
merged 2 commits into from Jul 18, 2022
Merged

Recognize exemplar record type in WAL watcher metrics #11008

merged 2 commits into from Jul 18, 2022

Conversation

LeviHarrison
Copy link
Member

I think this was left out when exemplar support was added. Without it when an exemplar record is read prometheus_wal_watcher_records_read_total{type="unknown"} is incremented, not ...{type="exemplar"}.

@LeviHarrison
Add exemplar record case
f41f414 
Signed-off-by: Levi Harrison <git@leviharrison.dev>
@LeviHarrison LeviHarrison mentioned this pull request Jul 12, 2022
Merged
codesome
codesome reviewed Jul 14, 2022
View reviewed changes
Copy link
Member

@codesome codesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid that from happening in future (yes we have more types coming up), how about we add a String() method for record.Type? And get rid of recordType() function that way.

@LeviHarrison
recordType() -> Type.String()
62eb2ad 
Signed-off-by: Levi Harrison <git@leviharrison.dev>
@LeviHarrison
Copy link
Member Author

Sounds good

@codesome codesome merged commit 3d53835 into prometheus:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codesome codesome codesome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeviHarrison @codesome