discovery/kubernetes: add container image as metadata #11034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds a __meta_kubernetes_pod_container_image as a new metadata label. This can be used to alert on mismatched versions of targets who don't have a build_info metric, as well as injecting it into log lines for other consumers of discovery/kubernetes (e.g., Promtail). Signed-off-by: Robert Fratto <robertfratto@gmail.com>
Signed-off-by: Robert Fratto <robertfratto@gmail.com>
|
Nice! |
brancz
approved these changes
Jul 19, 2022
valyala
added a commit
to VictoriaMetrics/VictoriaMetrics
that referenced
this pull request
Aug 14, 2022
…iner_image` label in the same way as Prometheus 2.38 does See prometheus/prometheus#11034
valyala
added a commit
to VictoriaMetrics/VictoriaMetrics
that referenced
this pull request
Aug 14, 2022
…iner_image` label in the same way as Prometheus 2.38 does See prometheus/prometheus#11034
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds
__meta_kubernetes_pod_container_imageas a new metadata label. This can be used to alert on mismatched versions of targets who don't have a build_info metric, as well as injecting it into log lines for other consumers of discovery/kubernetes (e.g., Promtail).A Grafana Agent user was asking for this metadata to be available for feature parity with Datadog.
Signed-off-by: Robert Fratto robertfratto@gmail.com