/-/{healthy,ready}/ respond to HEAD #11160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, thanks! I don't have much experience with HEAD requests in the wild, but https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/HEAD says, "A response to a HEAD method should not have a body.". Maybe just return the OK status code for HEAD and no message? (that then obviates the need for the message printer handler refactoring as well). |
Some frameworks issue HEAD requests to determine health. This resolves #11159 Signed-off-by: Nicolas Dumazet <nicdumz.commits@gmail.com>
|
Thanks Julius, I agree with you and I've updated the PR accordingly. |
|
👍 Thanks! |
nicdumz
added a commit
to nicdumz/alertmanager
that referenced
this pull request
Aug 16, 2022
Some frameworks issue HEAD requests to determine health. This is meant to be the alertmanager equivalent of prometheus/prometheus#11160 Signed-off-by: Nicolas Dumazet <nicdumz.commits@gmail.com>
Mama59
pushed a commit
to Arnoways/prometheus
that referenced
this pull request
Aug 25, 2022
Some frameworks issue HEAD requests to determine health. This resolves prometheus#11159 Signed-off-by: Nicolas Dumazet <nicdumz.commits@gmail.com> Signed-off-by: Nicolas Dumazet <nicdumz.commits@gmail.com>
simonpasquier
pushed a commit
to prometheus/alertmanager
that referenced
this pull request
Sep 9, 2022
Some frameworks issue HEAD requests to determine health. This is meant to be the alertmanager equivalent of prometheus/prometheus#11160 Signed-off-by: Nicolas Dumazet <nicdumz.commits@gmail.com> Signed-off-by: Nicolas Dumazet <nicdumz.commits@gmail.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Dec 13, 2022
Some frameworks issue HEAD requests to determine health. This is meant to be the alertmanager equivalent of prometheus/prometheus#11160 Signed-off-by: Nicolas Dumazet <nicdumz.commits@gmail.com> Signed-off-by: Nicolas Dumazet <nicdumz.commits@gmail.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some frameworks issue HEAD requests to determine health.
This resolves #11159
Signed-off-by: Nicolas Dumazet nicdumz.commits@gmail.com