-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsdb: turn off transaction isolation for head compaction #11317
Conversation
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
So that we can see when appending has moved past a certain point in time. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This will be used when for head compaction. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
68ededf
to
341a51d
Compare
CI failing on Windows only:
It seems to have read more data than was written? |
This saves a lot of work tracking appends done while compaction is ongoing. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
341a51d
to
7b62131
Compare
I did a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will have a very big impact on some of our instances that fall over into a memory death spiral.
…11317) * tsdb: add a basic test for read/write isolation * tsdb: store the min time with isolationAppender So that we can see when appending has moved past a certain point in time. * tsdb: allow RangeHead to have isolation disabled This will be used when for head compaction. * tsdb: do head compaction with isolation disabled This saves a lot of work tracking appends done while compaction is ongoing. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This saves a lot of work tracking appends done while compaction is ongoing.
head.compactable()
ensures that the end of the compaction range is more than chunkRange/2 back from now, andhead.appendableMinValidTime()
ensures that no new appends can start within the compaction range.We do need to wait for any overlapping appenders that started previously to finish.
Fixes #9253.