Add PromQL format and label matcher set/delete commands to promtool #11411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example usage: $ ./promtool promql format 'foo{bar="baz"}'
foo{bar="baz"}
$ ./promtool promql format 'foo{bar="baz"}/bar'
foo{bar="baz"} / bar
$ ./promtool promql label-matchers set 'foo{bar="baz"}/bar' 'qux' 'qaz'
foo{bar="baz",qux="qaz"} / bar{qux="qaz"}
$ ./promtool promql label-matchers delete 'foo{bar="baz"}/bar' 'bar'
foo / bar |
|
Realized I should have brought this up directly w/ Prometheus team first, have opened the discussion here: |
|
Sounds like there is consensus on the mailing list |
roidelapluie
force-pushed
the
add-promql-cmds-to-promtool
branch
from
be50301
to
4814ef5
Compare
Signed-off-by: Rob Skillington <rob@chronosphere.io> Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
roidelapluie
force-pushed
the
add-promql-cmds-to-promtool
branch
from
4814ef5
to
b3b669f
Compare
|
I have rebased this and added a |
juliusv
reviewed
Jul 12, 2023
docs/command-line/promtool.md
Outdated
|
|
||
| ### `promtool promql` | ||
|
|
||
| PromQL formatting and editing. Requires the --experimental flag. |
There was a problem hiding this comment.
Suggested change
| PromQL formatting and editing. Requires the --experimental flag. | |
| PromQL formatting and editing. Requires the `--experimental` flag. |
|
👍 otherwise |
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
roidelapluie
force-pushed
the
add-promql-cmds-to-promtool
branch
from
d908b5a
to
fd5b01a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #10544 which
intended later would be added the ability to format PromQL queries to
promtoolto allow formatting of PromQL queries and also setting/deleting label matchers
contained by a PromQL query (useful for programmatic manipulation of query
definitions).