Add '--run' flag to promtool test rules #12206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadovilaca
force-pushed
the
add-focus-flag-to-promtool-test-rules
branch
from
a1e2a74
to
f163fda
Compare
|
@dgl are you able to take a look at this? |
|
Can we find a more intuitive name for the flag? |
|
maybe --run, like go test? |
|
Hi @machadovilaca , we looked at this during our bug scrub, would you like to continue working on this pull request and update the flag name to |
|
@roidelapluie Hi, I've been a little short on time, thanks for the reminder and I'll make sure I take 10min to update the PR this week. |
Signed-off-by: João Vilaça <jvilaca@redhat.com>
machadovilaca
force-pushed
the
add-focus-flag-to-promtool-test-rules
branch
from
f163fda
to
81394ea
Compare
machadovilaca
changed the title
|
@roidelapluie updated |
|
@roidelapluie ping |
roidelapluie
approved these changes
Dec 5, 2023
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing unit tests for rules it would be helpful to be able to run only a single group and avoid testing all test groups in a single file.
This PR adds a new
--runflag topromtool test rulesthat allows users to pass multiple regular expressions to filter the test groups that will be run based on their names.