Document running golangci-lint and make it work on arm64 #12339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
reviewed
May 7, 2023
bboreham
approved these changes
May 11, 2023
|
Force-pushed to trigger the CI. Might have not run because of this Github incident. |
|
I would still keep the unused targets for now and keep backwards compat |
|
We have looked at this pull request during our bug scrub. Are you willing to continue to work on this? There is also a conflict on Makefile.common. Thank you for your contribution. |
Signed-off-by: Mickael Carl <mcarl@apple.com>
Signed-off-by: Mickael Carl <mcarl@apple.com>
mickael-carl
force-pushed
the
mcarl/lint
branch
from
5217ae0
to
420b324
Compare
|
@roidelapluie I've updated this now, limiting the change to only the required to get linting to work on arm64 + doc change. That should solve your concerns with the various removal I had in. |
roidelapluie
approved these changes
May 24, 2024
Signed-off-by: Julien <291750+roidelapluie@users.noreply.github.com>
roidelapluie
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While opening a different PR, I noticed that while the contributing guidelines do mention golangci-lint, there aren't instructions on how to run it. When running the Makefile target for it on an arm64 machine, it will immediately exits due to
arm64being missing from the list of supported architecture.Also removing some targets (precheck, common-staticcheck) that aren't in use anymore in any repo in the
prometheusorprometheus-communityorgs.