histogram: Identify native histograms even without observations #12584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Companion PR for prometheus/client_golang#1314 |
bwplotka
approved these changes
Jul 26, 2023
| @@ -1688,6 +1720,25 @@ func TestProtobufParse(t *testing.T) { | |||
| "__name__", "without_quantiles_sum", | |||
| ), | |||
| }, | |||
| { // 78 | |||
| m: "empty_histogram", | |||
| help: "A histogram without observations and with a zero threshold of zero but with a no-op spam to identify it as a native histogram.", | |||
There was a problem hiding this comment.
Suggested change
| help: "A histogram without observations and with a zero threshold of zero but with a no-op spam to identify it as a native histogram.", | |
| help: "A histogram without observations and with a zero threshold of zero but with a no-op span to identify it as a native histogram.", |
| @@ -965,6 +978,25 @@ func TestProtobufParse(t *testing.T) { | |||
| "__name__", "without_quantiles_sum", | |||
| ), | |||
| }, | |||
| { | |||
| m: "empty_histogram", | |||
| help: "A histogram without observations and with a zero threshold of zero but with a no-op spam to identify it as a native histogram.", | |||
There was a problem hiding this comment.
Suggested change
| help: "A histogram without observations and with a zero threshold of zero but with a no-op spam to identify it as a native histogram.", | |
| help: "A histogram without observations and with a zero threshold of zero but with a no-op span to identify it as a native histogram.", |
bwplotka
reviewed
Jul 26, 2023
| @@ -517,6 +517,19 @@ metric: < | |||
| sample_sum: 1.234 | |||
| > | |||
| > | |||
| `, | |||
| `name: "empty_histogram" | |||
| help: "A histogram without observations and with a zero threshold of zero but with a no-op spam to identify it as a native histogram." | |||
There was a problem hiding this comment.
ditto
Suggested change
| help: "A histogram without observations and with a zero threshold of zero but with a no-op spam to identify it as a native histogram." | |
| help: "A histogram without observations and with a zero threshold of zero but with a no-op span to identify it as a native histogram." |
|
No-op spam would be nice indeed… :o) Will fix and then merge. |
Native histograms without observations and with a zero threshold of zero look the same as classic histograms in the protobuf exposition format. According to prometheus/client_golang#1127 , the idea is to add a no-op span to those histograms to mark them as native histograms. This commit enables Prometheus to detect that no-op span and adds a doc comment to the proto spec describing the behavior. Signed-off-by: beorn7 <beorn@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native histograms without observations and with a zero threshold of zero look the same as classic histograms in the protobuf exposition format. According to
prometheus/client_golang#1127 , the idea is to add a no-op span to those histograms to mark them as native histograms. This commit enables Prometheus to detect that no-op span and adds a doc comment to the proto spec describing the behavior.