-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(lint): enable nolintlint and remove redundant comments #12926
Conversation
6c460f7
to
00a6592
Compare
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
00a6592
to
9cb1f86
Compare
Can you explain a little bit more background why we want this linter and why the comments are redundant, please? |
@bboreham yeah.
When I enabled
I fixed all these issues in this PR and removed 19 unnecessary code lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was reviewed during the Prometheus Bug Scrub event.
TIL about nolintlint and found it very cool 🎉
Thank you for the contribution.
Sorry I'm still missing why it is OK to delete the comments as you did. |
This PR enables
nolintlint
linter to check//nolint
comments. Also, removes redundant//nolint:
directives.