scraping: delay creating buffer, to save memory #12953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need the buffer to read the response until the scrape http call returns; creating it earlier makes the buffer pool larger. I split `scrape()` into `scrape()` which returns with the http response, and `readResponse()` which decompresses and copies the data into the supplied buffer. This design was chosen to minimize impact on the logic. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
roidelapluie
approved these changes
Oct 9, 2023
|
LGTM |
LeviHarrison
pushed a commit
to LeviHarrison/prometheus
that referenced
this pull request
Oct 15, 2023
We don't need the buffer to read the response until the scrape http call returns; creating it earlier makes the buffer pool larger. I split `scrape()` into `scrape()` which returns with the http response, and `readResponse()` which decompresses and copies the data into the supplied buffer. This design was chosen to minimize impact on the logic. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Levi Harrison <git@leviharrison.dev>
LeviHarrison
pushed a commit
to LeviHarrison/prometheus
that referenced
this pull request
Oct 15, 2023
We don't need the buffer to read the response until the scrape http call returns; creating it earlier makes the buffer pool larger. I split `scrape()` into `scrape()` which returns with the http response, and `readResponse()` which decompresses and copies the data into the supplied buffer. This design was chosen to minimize impact on the logic. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Levi Harrison <git@leviharrison.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need the buffer to read the response until the scrape http call returns; creating it earlier means we get a larger buffer pool.
I split the
scrape()method intoscrape()which returns with the http response, andreadResponse()which decompresses and copies the data into the supplied buffer. This design was chosen to minimize impact on the logic.Side-note:
sync.Poolcan still retain a lot more memory than we want it too, especially on many-core machines.Reducing
GOMAXPROCSdown to Prometheus' typical usage can reduce this effect.