Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSDB block index writer: reduce memory used by symbol cache #13056

Merged
merged 1 commit into from
Nov 13, 2023
Merged

TSDB block index writer: reduce memory used by symbol cache #13056

merged 1 commit into from
Nov 13, 2023

Conversation

songjiayang
Copy link
Contributor

@songjiayang songjiayang commented Oct 31, 2023 •
edited

the benchmark is:

BenchmarkSymbolCacheEntry_WithAlignment-4      	 5377081	       224.4 ns/op	     121 B/op	       0 allocs/op
BenchmarkSymbolCacheEntry_WithoutAlignment-4   	 6005053	       224.1 ns/op	     137 B/op	       0 allocs/op

@songjiayang
symbolCacheEntry field type alignment, thus saving 8 bytes.
443867f 
Signed-off-by: songjiayang <songjiayang1@gmail.com>
@songjiayang songjiayang force-pushed the symbolCacheEntry-filed-alignment branch from aaeb6f9 to 443867f Compare November 8, 2023 16:43
bboreham
bboreham approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot.

(Please, if you quote benchmark results, show the code of the benchmark.)

@bboreham bboreham changed the title saving memory with struct filed alignment for symbolCacheEntry TSDB block index writer: save memory in symbol cache Nov 13, 2023
@bboreham bboreham changed the title TSDB block index writer: save memory in symbol cache TSDB block index writer: reduce memory used by symbol cache Nov 13, 2023
@bboreham bboreham merged commit 37573d0 into prometheus:main Nov 13, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham approved these changes

@jesusvazquez jesusvazquez Awaiting requested review from jesusvazquez jesusvazquez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@songjiayang @bboreham