Fix issue where concatenatingChunkIterator can obscure errors
#13084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Korn <charles.korn@grafana.com>
|
Converting this back to draft while we investigate a possible issue with this change. |
|
This PR is good to go again, the issue was unrelated to this change. |
|
Any chance you could merge this @bboreham? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a similar issue to #13006, but this time for
concatenatingChunkIterator.If a consumer of a
concatenatingChunkIteratordoes not consume it all the way to the end (ie. untilNext()returnsfalse), it may not know to check for an error.With this PR,
concatenatingChunkIterator.Next()will instead begin returningfalseas soon as the current iterator reports an error.This PR upstreams the change from grafana/mimir-prometheus#549, which has already been tested in Mimir.