Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting issues blocking CI #13178

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

charleskorn
Copy link
Contributor

CI builds for main are failing due to minor linting issues. This PR fixes them.

I suspect these issues were introduced when #12622 was merged.

Signed-off-by: Charles Korn <charles.korn@grafana.com>
@charleskorn
Copy link
Contributor Author

The "Go tests on Windows" CI job seems to be failing for an unrelated reason, but I don't have permission to re-run the job.

@bboreham
Copy link
Member

Very similar to #13175, but without removing the comment on strings.Title.
I hit 're-run' on the Windows tests.
I don't see any previous complaints about TestDeletedSamplesAndSeriesStillInWALAfterCheckpoint being flaky.

Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bboreham bboreham merged commit 2329fba into prometheus:main Nov 23, 2023
23 checks passed
@fionaliao fionaliao mentioned this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants