Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent/db] Participate in Notify calls #13223

Merged

Conversation

jlevesy
Copy link
Contributor

@jlevesy jlevesy commented Nov 30, 2023

What does this PR do?

This PR allows the agent/db to participate in Notify calls when a Commit happens.

Relates to #13111
Supersedes #13188

@cstyan
Copy link
Member

cstyan commented Nov 30, 2023

@jlevesy can you add a changelog entry, imo this is a bugfix

@jlevesy jlevesy force-pushed the 13111/allow-agent-participate-notify-calls branch from a616fea to 2913e6a Compare November 30, 2023 18:45
@jlevesy
Copy link
Contributor Author

jlevesy commented Nov 30, 2023

Done!

Signed-off-by: Julien Levesy <jlevesy@gmail.com>
@jlevesy jlevesy force-pushed the 13111/allow-agent-participate-notify-calls branch from 2913e6a to be0beaa Compare November 30, 2023 18:47
Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: Callum Styan <callumstyan@gmail.com>
@cstyan cstyan merged commit 501f514 into prometheus:main Dec 1, 2023
24 checks passed
cstyan added a commit that referenced this pull request Dec 5, 2023
Signed-off-by: Julien Levesy <jlevesy@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Co-authored-by: Callum Styan <callumstyan@gmail.com>
@jlevesy jlevesy deleted the 13111/allow-agent-participate-notify-calls branch December 11, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants