Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded main and example Go dependencies pre 2.49-rc.0 #13255

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Dec 7, 2023

Pre step for 2.49-rc.0

Added cmd for documentation module update due to https://github.com/prometheus/prometheus/security/dependabot/92 & other similar alerts.

@bwplotka
Copy link
Member Author

bwplotka commented Dec 7, 2023

hmmmm

/go/pkg/mod/github.com/hashicorp/nomad/api@v0.0.0-20231206220849-8cde7a4f70c0/error_unexpected_response.go:11:2: package slices is not in GOROOT (/usr/local/go/src/slices)
!! command failed: build -o /__w/prometheus/prometheus/prometheus -ldflags -X github.com/prometheus/common/version.Version=2.48.0 -X github.com/prometheus/common/version.Revision=bc3ed6f8dc155b57f45c23fc40bf0e304dee1f9a -X github.com/prometheus/common/version.Branch=HEAD -X github.com/prometheus/common/version.BuildUser=root@d61296eb83cb -X github.com/prometheus/common/version.BuildDate=20231207-12:12:23  -extldflags '-static' -tags netgo,builtinassets,stringlabels github.com/prometheus/prometheus/cmd/prometheus: exit status 1
make: *** [Makefile.common:200: common-build] Error 1

Disabled that update for now.

@SuperQ
Copy link
Member

SuperQ commented Dec 7, 2023

This isn't really necessary anymore as we have dependabot that watches for Go updates.

@bwplotka
Copy link
Member Author

bwplotka commented Dec 7, 2023

True, but we don't do a good job of merging/reviewing/addressing blockers on those dependabot PRs, so far.

Anyway, was quicker for me to do one PR here than checking & fixing & rebasing 5+ dependabot PRs.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am objecting to this change. I think we can do a better job of using dependabot for what it's good for.

@bwplotka
Copy link
Member Author

bwplotka commented Dec 7, 2023

Hm, so that blocks having latest minor versions for all our Go packages on new release, are you sure?

I don't see how I can do it with dependabot at the moment (e.g. to include documentation go.mod). It periodically proposes PRs to upgrade some groups, plus it takes time to merge all groups one by one, wait for tests, rebase (every PR generate conflicts with go.mod) and repeat X times. Am I missing something? e.g. dependabot/dependabot-core#2980 ..even if there is some configuration to do, I don't have time to do it right now.

What's the harm in upgrading in bulk while we wait for improved dependabot and us reconfiguring things for better state? 🤔

@bboreham
Copy link
Member

bboreham commented Dec 7, 2023

I think the right way to change the release process would be to make a PR changing https://github.com/prometheus/prometheus/blob/main/RELEASE.md#manually-updating-go-dependencies

(I'm unclear how or if dependabot works, but ok to change the system given clear instructions)

@beorn7
Copy link
Member

beorn7 commented Dec 7, 2023

I think of dependabot as a tool helping the release shepherd. It's the release shepherd's call if they want to utilize it or not. AFAIK dependabot will simply close the PRs that aren't needed anymore because the dependency was updated manually.

@bwplotka bwplotka force-pushed the pre-2.49-up2 branch 2 times, most recently from 110688b to 0acf544 Compare December 7, 2023 15:28
Pre step for 2.49-rc.0

Added cmd for documentation module update due to https://github.com/prometheus/prometheus/security/dependabot/92 & other similar alerts.

Signed-off-by: bwplotka <bwplotka@gmail.com>
@bwplotka bwplotka merged commit f9ecc0d into main Dec 7, 2023
33 of 38 checks passed
@bwplotka bwplotka deleted the pre-2.49-up2 branch December 7, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants