New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agent: make the global hash lookup table smaller #13262
Conversation
5039ed1
to
8f56603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me @bboreham I understand that running prombench wont yield any results here because this is agent code but I let you chose if you want to run it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, have you benchmarked it somewhere? I bet you did, do you mind sharing screenshots for future reference? (:
I added a benchmark:
|
457e168
to
183f7c3
Compare
Got a lint error from a file I didn't change, so rebased and force-pushed. |
Lint error should be fixed by #13343 |
This is the same change made in prometheus#13040, plus subsequent improvements, applied to agent-mode code. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Based on the one in tsdb/head_test.go. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
183f7c3
to
bad3f23
Compare
This is the same change made in #13040, plus subsequent improvements, applied to agent-mode code.
Brought in some tests too, adapted for the different API.