promql: simplify Native Histogram arithmetics #13267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>
|
@beorn7 any comments on this? |
|
Thank you very much. This PR fell through the cracks over the holidays. (Feel free to @-mention me on histogram related PRs. The histogram related code is sprinkled all over the codebase so I cannot be auto-assigned to histogram-related PRs.) I will look at this ASAP. |
beorn7
approved these changes
Jan 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13208 has added support for reduction of resolution when adding/subtracting Native Histograms, so now these operations can be safely performed in any order, regardless of histogram schemas. Thanks to that change we can now simplify Native Histogram arithmetics in promql engine.
As a side effect, there will be some reduction of allocations when processing histograms with varying resolutions. Also, some
.Mul(-1)calls will now be avoided.