storage: skip merging when no remote storage configured #13427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus is hard-coded to use a fanout storage between TSDB and a remote storage which by default is empty. This change detects the empty storage and skips merging between result sets, which would make `Select()` sort results. Bottom line: we skip a sort unless there really is some remote storage configured. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
|
I am not familiar with |
|
Currently that optimization is done in Select(). You’re right it could move to the constructor, but I would see that as a separate change. |
|
/prombench main |
|
Big win: 10% CPU reduction, 30% faster instant queries.
(Arguably the benchmark queries are extreme, YMMV) |
|
/prombench cancel |
|
Benchmark cancel is in progress. |
This was referenced Jan 19, 2024
SuperQ
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus is hard-coded to use a fanout storage between TSDB and a remote storage which by default is empty.
This change detects the empty storage and skips merging between result sets, which would make
Select()sort results.Bottom line: we skip a sort unless there really is some remote storage configured.