Add more context cancellation check at evaluation time #13437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found out that even if the query already timed out and context canceled, the query is still running at evaluation phase.
This pr adds more context cancellation check when evaluating
parser.Call
andparser.VectorSelector
. We already have such kind of per series ctx cancellation check here.Example trace below. The query itself timed out after 1 min, but
promqlInnerEval eval parser.Call
ran for 3.4 min.