New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui (histograms): Add native histogram chart to Table view #13658
Conversation
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>
@juliusv here's what I have so far. I need to add some tests and there may be room to improve how we display the total count and sum but it felt off when adding those in the same table as range + count |
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>
…a/prometheus into add-histograms-table
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Hmm, it seems the |
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like it so far, thanks! Yeah, now seeing the count and sum outside of the bucket table, have to actually say that I prefer that too.
@@ -122,6 +122,128 @@ input[type='checkbox']:checked + label { | |||
color: $checked-checkbox-color; | |||
} | |||
|
|||
.summary-wrapper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call this .histogram-summary-wrapper
or something like that because otherwise it sounds very generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
width: 100%; | ||
bottom: 0; | ||
// background-color: #9090ff; | ||
// border: 1px solid #aaaaff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these commented-out lines still needed, or should they be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed
Signed-off-by: Manik Rana <manikrana54@gmail.com>
@juliusv this is pretty much done I'd say, only thing is I'm having trouble understanding why the UI test is failing.
A little bit unsure how to proceed. I could just forgo testing |
@Maniktherana Strange! Yes, I think it's ok to skip testing it for now. We shouldn't be spending too much on figuring out weirdness in Enzyme tests that we will have to throw away anyway with the new Mantine-based UI and React 18. |
Signed-off-by: Manik Rana <manikrana54@gmail.com>
👍 Do you want to press the "Ready for review" button to move the PR out of draft status? Then I'll merge it. |
Meh actually I'll just do it myself :) |
@juliusv Awesome, thanks! Ig there's some ancillary issues I can create like testing + optimizing histogram rendering |
@Maniktherana Thanks as well! Yeah I think functional / performance improvements would be more useful at the moment, with the current set of tests going away soon. I think in the new UI I will hide all the graph page settings in a collapsible section, which would make it easier to add even more settings in there - e.g. to configure how histograms should be displayed by default in the table. |
addresses #11269
This PR adds a better rendered view of native histograms in the table view. The histogram can be toggled between using a linear or exponential scale on the x-axis.
Screen.Recording.2024-02-28.at.10.32.30.AM.mov