Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] TSDB: Log more statistics during startup #13838

Merged

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Mar 25, 2024

…l replay duration

It would be useful to log chunk snapshot load duration and mmap chunk replay duration together with total_replay_duration log line so that it is easier to understand the WAL replay duration breakdown.

Previously the two fields are also logged but in separate log lines, which is hard to search and correlate with a specific WAL replay run.

…l replay duration

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Hello from the Bug Scrub Meeting)

LGTM, thanks!

@bboreham bboreham changed the title Log chunk snapshot and mmap chunks replay duration together with tota… [ENHANCEMENT] TSDB: Log more statistics during startup Mar 26, 2024
@bboreham bboreham merged commit ceca6c4 into prometheus:main Mar 26, 2024
24 checks passed
@yeya24 yeya24 deleted the log-chunk-replay-total-replay-duration branch March 26, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants