Fix parser.VectorSelector.String() with empty name matcher
#14015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
Apr 30, 2024
This illustrates the bug from Prometheus: prometheus/prometheus#14015 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
May 7, 2024
This includes the fix from prometheus/prometheus#14015 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
May 7, 2024
* Update mimir-prometheus to prometheus#14015 This includes the fix from prometheus/prometheus#14015 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> --------- Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
May 8, 2024
This illustrates the bug from Prometheus: prometheus/prometheus#14015 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
kushalShukla-web
pushed a commit
to kushalShukla-web/prometheus
that referenced
this pull request
May 13, 2024
…eus#14015) The check fell into "this matcher equals vector selector's name" case when vector selector doesn't have a name and the matcher is an explicit matcher for an empty __name__ label. To provide some context about why this is important: some downstream projects use the promql.Parse(expr.String()) to clone an expression's AST, and with this bug that matcher disappears in the cloning. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> Signed-off-by: kushagra Shukla <kushalshukla110@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check fell into "this matcher equals vector selector's name" case when vector selector doesn't have a name and the matcher is an explicit matcher for an empty
__name__label.To provide some context about why this is important: some downstream projects use the
promql.Parse(expr.String())to clone an expression's AST, and with this bug that matcher disappears in the cloning.