prometheusremotewrite: Move TimeSeries method to timeseries.go #14020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
changed the title
To facilitate generating OTel translation code for other Prometheus compatible backends, modify the prometheusremotewrite sources slightly so that the PrometheusConverter.TimeSeries method is in a file called timeseries.go. The rationale is to allow other backends to define their own implementation of this method. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
bwplotka
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate generating OTel translation code for other Prometheus compatible backends (e.g. Grafana Mimir/Thanos/Cortex), modify the
prometheusremotewritesources slightly so that thePrometheusConverter.TimeSeriesmethod is in a file called timeseries.go. The rationale is to allow other backends to define their own implementation of this method.The change has no practical effect, it's just code reorganizing.
At the same time taking the opportunity to format metrics_to_prw_test.go via
gofumpt -extra(golangci-lintcomplained about this locally).