Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: quote label name in matchers when needed #14068

Merged
merged 3 commits into from
May 14, 2024
Merged

Bugfix: quote label name in matchers when needed #14068

merged 3 commits into from
May 14, 2024

Commits on May 8, 2024

  1. Quote label name in matchers when needed 

    When the label name of a matcher contains non-standard characters, like
a dot, or starts with a digit, it should be quoted.

If it's not quoted, then `VectorSelector.String()` isn't a valid PromQL.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @colega
    colega committed May 8, 2024
    Configuration menu
    Copy the full SHA
    dabd789 View commit details
    Browse the repository at this point in the history

  2. Optimize Matcher.String() 

    Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @colega
    colega committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6ebda5a View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Use bytes.Buffer from stack buf in Matcher.String() 

    Also removed the growing until there's a benchmark for that.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
    @colega
    colega committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b7b4355 View commit details
    Browse the repository at this point in the history