[ENHANCEMENT] TSDB: Allow to stop waiting for pending queries #14088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If queries take a very long time to finish, perhaps because something has gone wrong, we would prefer operations like `Compact()`` to be interruptible so we can shut down cleanly. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
| @@ -1082,7 +1082,7 @@ func (h *Head) SetMinValidTime(minValidTime int64) { | |||
| // Truncate removes old data before mint from the head and WAL. | |||
| func (h *Head) Truncate(mint int64) (err error) { | |||
There was a problem hiding this comment.
Is there a reason why you did not pass the context here as well?
There was a problem hiding this comment.
Mainly I couldn't see where this was called except from reload, where we don't seem to have a useful context.
But I can add it for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If queries take a very long time to finish, perhaps because something has gone wrong, we would prefer operations like `Compact()`` to be interruptible so we can shut down cleanly.