Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the slow updates of targets changes #4526

Merged
merged 1 commit into from Sep 26, 2018

Commits on Sep 26, 2018

  1. process scrape loops reloading in parallel

    The scrape manage receiver channel now just saves the target sets
    and another backgorund runner updates the scrape loops every 5 seconds.
    This is so that the scrape manager doesn't block the receiving channel
    when it does the long background reloading of the scrape loops.
    
    Active and dropped targets are now saved in each scrape pool instead of
    the scrape manager. This is mainly to avoid races when getting the
    targets via the web api.
    
    When reloading the scrape loops now happens in parallel to speed up the
    final disared state and this also speeds up the prometheus's shutting
    down.
    
    Also updated some funcs signatures in the web package for consistency.
    
    Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
    Krasi Georgiev committed Sep 26, 2018
    Copy the full SHA
    eda48a2 View commit details
    Browse the repository at this point in the history