*: move to go 1.11 #4626

simonpasquier · 2018-09-18T13:09:16Z

No description provided.

gouthamve · 2018-09-18T13:12:17Z

While I'm not against it, it is worth noting that this is going to break a lot of kubernetes users badly (including me). See: golang/go#27546

grobie · 2018-09-18T13:14:57Z

@gouthamve Why? Prometheus doesn't use the native go DNS client.

simonpasquier · 2018-09-18T13:31:53Z

/benchmark pr

gouthamve · 2018-09-18T13:34:27Z

@grobie I didn't know that. We upgraded Cortex and that broke some stuff, best test it out though. I'll deploy this one soon.

simonpasquier · 2018-09-18T13:36:15Z

Yeah, I would definitely be cautious with this change: DNS + Go is a finicky topic.

simonpasquier · 2018-09-18T13:37:51Z

/benchmark

prombot · 2018-09-18T13:37:55Z

@simonpasquier: Benchmarking is restricted to org members.

In response to this:

/benchmark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gouthamve · 2018-09-18T14:07:05Z

/benchmark

prombot · 2018-09-18T14:07:07Z

@gouthamve: Welcome to Prometheus Benchmarking Tool.

The two prometheus versions that will be compared are pr-4626 and master

The logs can be viewed at the links provided in the GitHub check blocks at the end of this conversation

After successfull deployment, the benchmarking metrics can be viewed at :

promethues-meta - label {"namespace" : "prombench-4626"}
grafana - template-variable "pr-number" : 4626

To stop the benchmark process comment /benchmark cancel .

In response to this:

/benchmark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

simonpasquier · 2018-09-18T14:08:06Z

/benchmark cancel

prombot · 2018-09-18T14:08:09Z

@simonpasquier: Looks like start-benchmark job is already running on this PR. Will start cancel-benchmark job once ongoing job is completed

In response to this:

/benchmark cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gouthamve · 2018-09-18T14:08:11Z

/benchmark cancel

prombot · 2018-09-18T14:08:15Z

@gouthamve: Looks like a job is already lined up for this PR.
Please try again once all pending jobs have finished 😃

In response to this:

/benchmark cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

simonpasquier · 2018-09-18T14:42:37Z

/benchmark

prombot · 2018-09-18T14:42:39Z

@simonpasquier: Welcome to Prometheus Benchmarking Tool.

The two prometheus versions that will be compared are pr-4626 and master

The logs can be viewed at the links provided in the GitHub check blocks at the end of this conversation

After successfull deployment, the benchmarking metrics can be viewed at :

promethues-meta - label {"namespace" : "prombench-4626"}
grafana - template-variable "pr-number" : 4626

To stop the benchmark process comment /benchmark cancel .

In response to this:

/benchmark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

simonpasquier · 2018-09-18T15:52:16Z

/benchmark cancel

simonpasquier · 2018-09-18T15:58:18Z

/benchmark pr

sipian · 2018-09-18T16:20:23Z

@simonpasquier Acc to https://github.com/prometheus/prombench#how-to-trigger-tests-on-github

A Prometheus maintainer can comment as follows to benchmark a PR:
/benchmark <-- This will benchmark PR with the master branch.
/benchmark master
/benchmark 2.4.0 <-- Any release version can be added here. Don't prepend v to the release version.
To cancel benchmarking, a mantainer should comment /benchmark cancel.

Benchmarking will always include the PR.
You need to specify the release version with which you want to compare the PR (master | previous-release)

prombot · 2018-09-18T16:20:25Z

@sipian: Benchmarking is restricted to org members.

In response to this:

@simonpasquier Acc to https://github.com/prometheus/prombench#how-to-trigger-tests-on-github

A Prometheus maintainer can comment as follows to benchmark a PR:
/benchmark <-- This will benchmark PR with the master branch.
/benchmark master
/benchmark 2.4.0 <-- Any release version can be added here. Don't prepend v to the release version.
To cancel benchmarking, a mantainer should comment /benchmark cancel.

Benchmarking will always include the PR.
You need to specify the release version with which you want to compare the PR (master | previous-release)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

simonpasquier · 2018-09-18T16:24:19Z

@sipian yep but there are some places that still reference /benchmark pr. I'll send a PR to fix some of the documentation on prombench.

sipian · 2018-09-18T16:26:24Z

Aah
Thanks for pointing this out.
[EDIT]
prometheus/test-infra#155

simonpasquier · 2018-09-18T20:41:33Z

/benchmark

prombot · 2018-09-18T20:41:34Z

@simonpasquier: Welcome to Prometheus Benchmarking Tool.

The two prometheus versions that will be compared are pr-4626 and master

The logs can be viewed at the links provided in the GitHub check blocks at the end of this conversation

After successfull deployment, the benchmarking metrics can be viewed at :

promethues-meta - label {"namespace" : "prombench-4626"}
grafana - template-variable "pr-number" : 4626

To stop the benchmark process comment /benchmark cancel .

In response to this:

/benchmark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

simonpasquier · 2018-10-02T09:32:54Z

Regarding the DNS service discovery, @grobie noted correctly that it uses https://github.com/miekg/dns instead of the native Go client so it should be immune to golang/go#27546. I did a test with a domain query returning a bunch of SRV records and it worked fine. Again not saying that it is sufficient and additional testing would be much appreciated.

krasi-georgiev · 2018-10-08T07:50:12Z

/benchmark

prombot · 2018-10-08T07:50:15Z

@krasi-georgiev: Welcome to Prometheus Benchmarking Tool.

The two prometheus versions that will be compared are pr-4626 and master

The logs can be viewed at the links provided in the GitHub check blocks at the end of this conversation

After successfull deployment, the benchmarking metrics can be viewed at :

prometheus-meta - label {namespace="prombench-4626"}
grafana - template-variable "pr-number" : 4626

To stop the benchmark process comment /benchmark cancel .

In response to this:

/benchmark

If you have questions or suggestions related to my behavior, please file an issue against the prometheus/prombench repository.

simonpasquier · 2018-10-08T15:40:08Z

/benchmark cancel

simonpasquier · 2018-10-09T08:15:54Z

/benchmark 2.4.2

prombot · 2018-10-09T08:15:56Z

@simonpasquier: Welcome to Prometheus Benchmarking Tool.

The two prometheus versions that will be compared are pr-4626 and v2.4.2

The logs can be viewed at the links provided in the GitHub check blocks at the end of this conversation

After successfull deployment, the benchmarking metrics can be viewed at :

prometheus-meta - label {namespace="prombench-4626"}
grafana - template-variable "pr-number" : 4626

To stop the benchmark process comment /benchmark cancel .

In response to this:

/benchmark 2.4.2

If you have questions or suggestions related to my behavior, please file an issue against the prometheus/prombench repository.

simonpasquier · 2018-10-09T13:21:18Z

no big differences between the v2.4.2 (go1.10.3) and go1.11 builds apart a very small decrease of CPU usage with 1.11.

/benchmark cancel

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

simonpasquier · 2018-10-09T14:36:36Z

As mentioned on IRC, Prometheus v2.4.3 is already built with go1.11.1 as promu had switched its default Go version to 1.11 before v2.4.3 was released. To prevent this from happening again, this PR also sets the Go version in .promu.yml.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

hoffie · 2018-10-10T19:25:11Z

@simonpasquier
There are reports of go1.11 allocating more virtual memory than earlier versions: golang/go#28114

Not sure if relevant for Prometheus (did not try). It could be just cosmetic. Mentioning just in case any such reports come in. Maybe v2.4.3 having been released without feedback regarding this is already a positive sign that this is a non-issue.

simonpasquier · 2018-10-11T07:45:28Z

@hoffie thanks for the pointer! I double-checked and the benchmark didn't anything particular wrt virtual memory utilization:

http://prombench.prometheus.io/prometheus-meta/graph?g0.range_input=6h&g0.end_input=2018-10-09%2014%3A00&g0.expr=process_virtual_memory_bytes%7Bjob%3D%22prometheus%22%2C%20namespace%3D%22prombench-4626%22%7D&g0.tab=0

simonpasquier · 2018-10-15T15:10:20Z

As noted above, v2.4.3 has already been built with go1.11.1 so I'd say that this PR is ok to go.

@gouthamve @brian-brazil WDYT?

brian-brazil · 2018-10-15T16:22:25Z

👍

grobie

LGTM

prombot added the benchmark label Sep 18, 2018

prombot added the pending-benchmark-job label Sep 18, 2018

prombot removed pending-benchmark-job benchmark labels Sep 18, 2018

prombot added the benchmark label Sep 18, 2018

prombot removed the benchmark label Sep 18, 2018

simonpasquier force-pushed the go-1.11 branch from b11aa74 to 46925ff Compare September 18, 2018 16:03

prombot removed the benchmark label Sep 18, 2018

simonpasquier force-pushed the go-1.11 branch from 46925ff to 1eb4fed Compare September 20, 2018 11:22

simonpasquier mentioned this pull request Oct 1, 2018

circleci: store build outputs as artifacts #4685

Merged

simonpasquier mentioned this pull request Oct 3, 2018

Replace prometheus-builder by promrunner prometheus/test-infra#163

Open

simonpasquier force-pushed the go-1.11 branch from 1eb4fed to a05a655 Compare October 4, 2018 07:08

prombot added the benchmark label Oct 8, 2018

prombot removed the benchmark label Oct 8, 2018

prombot added the benchmark label Oct 9, 2018

simonpasquier force-pushed the go-1.11 branch from 9aa7a2d to 4fa2b6f Compare October 9, 2018 10:00

prombot removed the benchmark label Oct 9, 2018

*: move to go 1.11

f4a7eec

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

simonpasquier force-pushed the go-1.11 branch 2 times, most recently from 1230a55 to 18b0277 Compare October 9, 2018 14:20

Reduce number of places where we specify the Go version

9b89b75

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

simonpasquier force-pushed the go-1.11 branch from 18b0277 to 9b89b75 Compare October 10, 2018 08:36

grobie approved these changes Oct 15, 2018

View reviewed changes

simonpasquier merged commit c4a6acf into prometheus:master Oct 16, 2018

simonpasquier deleted the go-1.11 branch October 16, 2018 07:44

*: move to go 1.11 #4626

*: move to go 1.11 #4626

Conversation

simonpasquier commented Sep 18, 2018

gouthamve commented Sep 18, 2018

grobie commented Sep 18, 2018

simonpasquier commented Sep 18, 2018

gouthamve commented Sep 18, 2018

simonpasquier commented Sep 18, 2018

simonpasquier commented Sep 18, 2018

prombot commented Sep 18, 2018

gouthamve commented Sep 18, 2018

prombot commented Sep 18, 2018

simonpasquier commented Sep 18, 2018

prombot commented Sep 18, 2018

gouthamve commented Sep 18, 2018

prombot commented Sep 18, 2018

simonpasquier commented Sep 18, 2018

prombot commented Sep 18, 2018

simonpasquier commented Sep 18, 2018

simonpasquier commented Sep 18, 2018

sipian commented Sep 18, 2018

prombot commented Sep 18, 2018

simonpasquier commented Sep 18, 2018

sipian commented Sep 18, 2018 • edited

simonpasquier commented Sep 18, 2018

prombot commented Sep 18, 2018

simonpasquier commented Oct 2, 2018

krasi-georgiev commented Oct 8, 2018

prombot commented Oct 8, 2018

simonpasquier commented Oct 8, 2018

simonpasquier commented Oct 9, 2018

prombot commented Oct 9, 2018

simonpasquier commented Oct 9, 2018

simonpasquier commented Oct 9, 2018

hoffie commented Oct 10, 2018

simonpasquier commented Oct 11, 2018

simonpasquier commented Oct 15, 2018

brian-brazil commented Oct 15, 2018

grobie left a comment

Choose a reason for hiding this comment

sipian commented Sep 18, 2018 •

edited