Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2 Platform meta label #4663

Merged
merged 2 commits into from Nov 6, 2018
Merged

EC2 Platform meta label #4663

merged 2 commits into from Nov 6, 2018

Conversation

sgissi
Copy link
Contributor

@sgissi sgissi commented Sep 26, 2018

Set __meta_ec2_platform label with the instance platform string. Set to 'windows' on Windows servers and absent otherwise. This is the only way to distinguish Linux from Windows EC2 instances.

Signed-off-by: Silvio Gissi silvio@gissilabs.com

Set __meta_ec2_platform label with the instance platform string. Set to 'windows' on Windows servers and absent otherwise.

Signed-off-by: Silvio Gissi <silvio@gissilabs.com>
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgissi
Copy link
Contributor Author

sgissi commented Oct 20, 2018

@fabxc @brian-brazil Can one of you review if you have time? Pretty small change.

@@ -406,6 +406,7 @@ The following meta labels are available on targets during [relabeling](#relabel_
* `__meta_ec2_instance_type`: the type of the EC2 instance
* `__meta_ec2_owner_id`: the ID of the AWS account that owns the EC2 instance
* `__meta_ec2_primary_subnet_id`: the subnet ID of the primary network interface, if available
* `__meta_ec2_platform`: the Operating System platform, set to 'windows' on Windows servers, absent otherwise
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it sorted

Signed-off-by: Silvio Gissi <silvio@gissilabs.com>
@sgissi
Copy link
Contributor Author

sgissi commented Nov 5, 2018

@brian-brazil PTAL. Thanks for the review.

@brian-brazil brian-brazil merged commit 6100f16 into prometheus:master Nov 6, 2018
@brian-brazil
Copy link
Contributor

Thanks!

@sgissi sgissi deleted the ec2_platform_property branch November 6, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants