Update moment.js and moment-timezone.js #4679

noqcks · 2018-09-29T19:54:40Z

Fixes #4563

This updates two of the moment packages.

simonpasquier · 2018-10-01T10:58:02Z

LGTM. I'm not at all knowledgeable on JavaScript but do we even need the moment-timezone library?

noqcks · 2018-10-06T23:00:38Z

Looks like moment-timezone was included in this PR: #3182

It seems like it's used with bootstrap-datetimepicker: Eonasdan/tempus-dominus#1725 (comment)

Valid to keep it considering we are using the timezone parameter for datetimepicker.

I don't have merge rights on this repo. So up to you @simonpasquier. thnx

Signed-off-by: noqcks <benny@noqcks.io>

simonpasquier · 2018-10-08T09:07:54Z

Thanks for the investigation! 👍 for me

noqcks · 2018-10-09T16:41:18Z

@simonpasquier how do I get it merged in ?

simonpasquier · 2018-10-10T07:37:33Z

@brian-brazil can you have a look at this? I've tested the PR locally and the UI looks ok.

brian-brazil · 2018-10-10T08:48:13Z

Thanks!

noqcks force-pushed the issue-4563 branch from 66810e6 to 8e4392e Compare September 29, 2018 19:55

noqcks added 3 commits October 7, 2018 11:49

upgrading moment-timezome (0.5.13 -> 0.5.17)

4a00d4f

Signed-off-by: noqcks <benny@noqcks.io>

upgrading dependency moment (2.16.0 -> 2.22.2)

0e02bbd

Signed-off-by: noqcks <benny@noqcks.io>

run make assets to update assets_vfsdata.go

4734d65

Signed-off-by: noqcks <benny@noqcks.io>

noqcks force-pushed the issue-4563 branch from 8e4392e to 16215b8 Compare October 7, 2018 15:50

pulling master & updating vfsdata with make assets

b4951cb

Signed-off-by: noqcks <benny@noqcks.io>

noqcks force-pushed the issue-4563 branch from 16215b8 to b4951cb Compare October 7, 2018 15:51

brian-brazil merged commit eb4cc37 into prometheus:master Oct 10, 2018

Provide feedback