Use the latest versions of azure go sdk and go-autorest #5015
Conversation
tariq1890
force-pushed
the
latest_azure
branch
from
9b35073
to
41ff511
Compare
tariq1890
changed the title
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
tariq1890
force-pushed
the
latest_azure
branch
from
41ff511
to
6be8128
Compare
There was a problem hiding this comment.
This change bumps a few dependencies like github.com/grpc-ecosystem/grpc-gateway and google.golang.org/grpc because of the newly added dependency on go.opencensus.io (through github.com/Azure/go-autorest -> contrib.go.opencensus.io/exporter/ocagent).
And because github.com/Azure/go-autorest doesn't use Go modules (unfortunately), Go can't determine which version of contrib.go.opencensus.io/exporter/ocagent it should depend on and it takes the latest tag. To match with the Gopkg.lock, we should pin contrib.go.opencensus.io/exporter/ocagent to v0.2.0.
|
Filed Azure/go-autorest#353 |
|
cc @sylr @marratj @jannickfahlbusch @johscheuer who have recently contributed fixes and improvements to the Azure SD and might be able to test this PR once it is ready. |
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
|
I can test this after this got merged 😊 However, as #4719 just fixes a silenced error everything should be fine from this PR. |
|
Just to make this clear, this PR is a work in progress. So it may go through significant changes. Reviews are always welcomed from everyone :) |
…o latest_azure
Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
tariq1890
force-pushed
the
latest_azure
branch
from
0cba755
to
65127d7
Compare
…o latest_azure
…o latest_azure
…o latest_azure
|
@tariq1890 could you resolve the conflicts? |
|
@simonpasquier Thanks for the follow-up on this PR. I will get to working on this :) |
tariq1890
force-pushed
the
latest_azure
branch
from
362577f
to
38c49bd
Compare
Signed-off-by: tariqibrahim <tariq181290@gmail.com>
tariq1890
force-pushed
the
latest_azure
branch
from
38c49bd
to
6407693
Compare
tariq1890
changed the title
|
Ready for another round of review @simonpasquier @brian-brazil |
tariq1890
changed the title
tariq1890
force-pushed
the
latest_azure
branch
2 times, most recently
from
42e22de
to
a1c6139
Compare
Signed-off-by: tariqibrahim <tariq181290@gmail.com>
tariq1890
force-pushed
the
latest_azure
branch
from
a1c6139
to
96985b4
Compare
Signed-off-by: tariqibrahim <tariq181290@gmail.com>
Signed-off-by: tariqibrahim <tariq181290@gmail.com>
There was a problem hiding this comment.
This LGTM. As I wrote in #4719, we're in master freeze so any merging is delayed.
Signed-off-by: tariqibrahim <tariq181290@gmail.com>
|
@simonpasquier I addressed the additional review comments as suggested by you in #4719 @jannickfahlbusch I request you to be ready to rebase your PR as soon as this is merged, so that your fix may be moved in at the earliest. Also requesting @sylr @jannickfahlbusch @marratj to validate this. I have tested this on my local setup and it seems to work fine. |
|
@tariq1890 I just tested your latest commit in our Azure environment and discovery works fine :-) |
|
@brian-brazil Requesting your review |
|
Thanks! |
) Signed-off-by: tariqibrahim <tariq181290@gmail.com> (cherry picked from commit f4275d2)
Update Azure-Go-SDK to 23.2.0
Update Go-Autorest to 11.2.8
The current build of Azure Go SDK is over 2 years old. It would be in the best interests to keep the Azure deps updated. Also, the querying of PowerStates requires us to use more recent. versions of the Go SDK (refer to #4908 )
Feedback is appreciated :). The changes worth noting can be seen in
azure.goandazure_test.go. There are changes in the method signatures and type structure which I thought might be of interest to the reviewers.