added EC2 InstanceLifecycle info as label (new label called lifecycle) #6017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aesiliato <antonioesiliato@ip-192-168-21-54.eu-west-1.compute.internal>
| if inst.InstanceLifecycle != nil { | ||
| labels[ec2LabelLifecycle] = model.LabelValue(*inst.InstanceLifecycle) | ||
| } else { | ||
| labels[ec2LabelLifecycle] = "normal" |
There was a problem hiding this comment.
Let's expose what the API exposes, rather than changing it.
There was a problem hiding this comment.
AWS console applies the same concept as you can see in the attached images... Anyway currently Prometheus cannot retrieve the InstanceLifecycle info even when the API exposes it
There was a problem hiding this comment.
We expose what the API exposes, not whatever munging other systems may do on top.
| @@ -54,6 +54,7 @@ require ( | |||
| github.com/prometheus/client_golang v1.1.0 | |||
| github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4 | |||
| github.com/prometheus/common v0.6.0 | |||
| github.com/prometheus/procfs v0.0.4 // indirect | |||
ghost
mentioned this pull request
|
Superseded by #6914 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: aesiliato
NB:
AWS API shows InstanceLifecycle in ec2 describe instances result only if the instance is a spot one. The new feature set value of lifecycle label = normal if InstanceLifecycle doesn't exist on describe instances results.