React UI: Send cookies on fetch() on older browsers #6553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonpasquier Do you have one of those older browsers lying around to test this? |
|
I don't have one but I can ask the person that reported the issue originally. |
|
@simonpasquier That'd be cool! Also fixed the tests. |
Fixes #6428 Signed-off-by: Julius Volz <julius.volz@gmail.com>
Signed-off-by: Julius Volz <julius.volz@gmail.com>
juliusv
force-pushed
the
react-ui-fix-credentials-default
branch
from
9b6f34e
to
c87c60d
Compare
|
Rebased on master. @simonpasquier Any news here from users, or should we just merge it? |
|
No news yet. I think it's fine to merge as-is. |
|
Ok thanks, merging... |
boyskila
pushed a commit
to boyskila/prometheus
that referenced
this pull request
Jan 25, 2020
* React UI: Send cookies on fetch() on older browsers Fixes prometheus#6428 Signed-off-by: Julius Volz <julius.volz@gmail.com> * Fix fetch() tests to expect new options Signed-off-by: Julius Volz <julius.volz@gmail.com>
|
/prombench v2.15.2 |
|
/prombench cancel |
|
Benchmark cancel is in progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6428
Signed-off-by: Julius Volz julius.volz@gmail.com