docs: add promtool version in rule migration cmd #6989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can we be shorter and more pragmatic? |
hoffie
force-pushed
the
docs-migration-promtool-rules
branch
2 times, most recently
from
1e402d7
to
d87e909
Compare
|
Tried to condense it into a single sentence. If you think it should be shortened even further, we would need to drop details, I think. |
hoffie
force-pushed
the
docs-migration-promtool-rules
branch
from
d87e909
to
f5485e5
Compare
`promtool update rules` is no longer available after Prometheus 2.5. Document this to avoid confusion such as in prometheus#6988. Signed-off-by: Christian Hoffmann <mail@hoffmann-christian.info>
hoffie
force-pushed
the
docs-migration-promtool-rules
branch
from
f5485e5
to
ab2488d
Compare
|
Thanks! |
damnever
pushed a commit
to damnever/prometheus
that referenced
this pull request
Sep 9, 2020
`promtool update rules` is no longer available after Prometheus 2.5. Document this to avoid confusion such as in prometheus#6988. Signed-off-by: Christian Hoffmann <mail@hoffmann-christian.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
promtool update rulesis no longer available after Prometheus 2.5.Document this to avoid confusion such as in #6988.