Adds support to build promql parser in CI #7516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> remove manual install goyacc Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> install goyacc manually Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
Harkishen-Singh
force-pushed
the
build-promql-parser
branch
from
b989a39
to
beb906c
Compare
roidelapluie
reviewed
Jul 5, 2020
Makefile
Outdated
| .PHONY: promql-parser | ||
| promql-parser: | ||
| @echo ">> running check for promql-parser build" | ||
| go get -u golang.org/x/tools/cmd/goyacc |
There was a problem hiding this comment.
somehow that would change the go mod?
There was a problem hiding this comment.
I think goyacc should be installed in circleci config, not in the makefile
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
|
@roidelapluie can you give a look at why is the test failing, and a possible suggestion to fix it? |
|
@roidelapluie any views? |
…build-promql-parser
|
ping @roidelapluie |
codesome
reviewed
Jul 12, 2021
There was a problem hiding this comment.
LGTM in general, but I have less context around this one. @roidelapluie could you give it another look since you had some comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com
Fixes: #7488
From pipeline