Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add major version tag #8026

Merged
merged 1 commit into from Oct 22, 2020
Merged

Conversation

vears91
Copy link
Contributor

@vears91 vears91 commented Oct 7, 2020

When the latest tag is added, also add a tag for the major version
when the version tag matches the latest release defined in VERSION.

Closes #7824

@roidelapluie
Copy link
Member

roidelapluie commented Oct 7, 2020

Can we check that release candidates do not get this tag ? @SuperQ @simonpasquier WDYT?

Makefile.common Outdated Show resolved Hide resolved
@SuperQ
Copy link
Member

SuperQ commented Oct 8, 2020

@roidelapluie We control the make docker-tag-latest from the CircleCI configuration, which doesn't tag latest on pre-releases.

Makefile.common Outdated Show resolved Hide resolved
When the latest tag is added, also add a tag for the major version
when the version tag matches the latest release defined in VERSION.

Signed-off-by: Victor Araujo <vear91@gmail.com>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@roidelapluie roidelapluie merged commit 74775d7 into prometheus:master Oct 22, 2020
@roidelapluie
Copy link
Member

Thanks!

@ozboss
Copy link

ozboss commented Jan 3, 2021

Is this available yet? I tried ":2" and ":v2" both did not work.

@roidelapluie
Copy link
Member

I missed that we do not push the image, and that we also tag the RC releases with this(which we should not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus v2 docker tag
4 participants