discovery/kubernetes: Fix valid label selector causing config error #8285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashumkin
force-pushed
the
label-selector
branch
from
565266e
to
39bc12c
Compare
|
@brancz does this look right to you? |
Label selector can be "set-based"(https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#set-based-requirement) but such a selector causes Prometheus start failure with the "unexpected error: parsing YAML file ...: invalid selector: 'foo in (bar,baz)'; can't understand 'baz)'"-like error. This is caused by the `fields.ParseSelector(string)` function that simply splits an expression as a CSV-list, so a comma confuses such a parsing method and lead to the error. Use `labels.Parse(string)` to use a valid lexer to parse a selector expression. Closes prometheus#8284. Signed-off-by: Alexey Shumkin <Alex.Crezoff@gmail.com>
ashumkin
force-pushed
the
label-selector
branch
from
39bc12c
to
73ddf60
Compare
|
any feedback? |
|
Sorry, it is a bit quiet due to the holidays period. cc @olagacek does this look fine to you? thanks! |
brancz
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Label selector can be
"set-based"(https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#set-based-requirement)
but such a selector causes Prometheus start failure with the "unexpected
error: parsing YAML file ...: invalid selector: 'foo in (bar,baz)';
can't understand 'baz)'"-like error.
This is caused by the
fields.ParseSelector(string)function thatsimply splits an expression as a CSV-list, so a comma confuses such a
parsing method and lead to the error.
Use labels.Parse(string) to use a valid lexer to parse a selector
expression.
Closes #8284.
Signed-off-by: Alexey Shumkin Alex.Crezoff@gmail.com