Fixed TestChunkDiskMapper_WriteChunk_Chunk_IterateChunks for go1.16 #8538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8403 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
commented
Feb 23, 2021
| @@ -118,11 +118,6 @@ func TestChunkDiskMapper_WriteChunk_Chunk_IterateChunks(t *testing.T) { | |||
| fileEnd := HeadChunkFileHeaderSize + len(expectedBytes) | |||
| require.Equal(t, expectedBytes, actualBytes[HeadChunkFileHeaderSize:fileEnd]) | |||
|
|
|||
| // Test for the next chunk header to be all 0s. That marks the end of the file. | |||
| for _, b := range actualBytes[fileEnd : fileEnd+MaxHeadChunkMetaSize] { | |||
There was a problem hiding this comment.
I double-checked and we don't need this assertion. If anything is wrong here (some of those bytes are non-zero), IterateAllChunks will fail with CorruptionErr anyway:
prometheus/tsdb/chunks/head_chunks.go
Line 574 in 0adfa7c
|
cc @codesome |
codesome
approved these changes
Feb 25, 2021
jwendell
pushed a commit
to jwendell/prometheus
that referenced
this pull request
Oct 17, 2023
…rometheus#8538) Fixes prometheus#8403 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
openshift-ci bot
pushed a commit
to maistra/prometheus
that referenced
this pull request
Oct 17, 2023
…rometheus#8538) Fixes prometheus#8403 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8403
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com