Improve styling of selected exemplar details #8945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't perfect yet, but IMO better than the initial draft. Signed-off-by: Julius Volz <julius.volz@gmail.com>
|
@LeviHarrison Would be cool to squeeze this in last-minute before the release 😄 |
|
Looking now 👀 |
|
Also would be great to get #8909 in before release |
Forgot that wasn't merged yet, thanks for the reminder! Done. |
LeviHarrison
approved these changes
Jun 15, 2021
roidelapluie
approved these changes
Jun 15, 2021
| @@ -6,6 +6,9 @@ import { Legend } from './Legend'; | |||
| import { Metric, ExemplarData, QueryParams } from '../../types/types'; | |||
| import { isPresent } from '../../utils'; | |||
| import { normalizeData, getOptions, toHoverColor } from './GraphHelpers'; | |||
| import { Button } from 'reactstrap'; | |||
| import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; | |||
There was a problem hiding this comment.
Does this load it locally or via CDN's?
There was a problem hiding this comment.
Locally, we already use this icon in other places as well.
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't perfect yet, but IMO better than the initial draft.
test-2021-06-15_22.27.00.mp4
Signed-off-by: Julius Volz julius.volz@gmail.com