Promtool: Add feature flags to unit tests #8958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
cmd/promtool/main.go
Outdated
| @@ -39,6 +39,7 @@ import ( | |||
| "github.com/prometheus/common/model" | |||
| "github.com/prometheus/common/version" | |||
| "github.com/prometheus/exporter-toolkit/web" | |||
| "github.com/prometheus/prometheus/promql" | |||
cmd/promtool/main.go
Outdated
| @@ -162,6 +163,8 @@ func main() { | |||
| "A list of one or more files containing recording rules to be backfilled. All recording rules listed in the files will be backfilled. Alerting rules are not evaluated.", | |||
| ).Required().ExistingFiles() | |||
|
|
|||
| featureList := app.Flag("enable-feature", "Comma separated feature names to enable (only PromQL related). Valid options: promql-at-modifier, promql-negative-offset. See https://prometheus.io/docs/prometheus/latest/disabled_features/ for more details.").Default("").Strings() | |||
There was a problem hiding this comment.
How could we keep that in sync with cmd/prometheus? Maybe we should just link to the web page?
There was a problem hiding this comment.
Sure, that sounds good
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds feature flag support to Promtool unit tests.
(Partially) Fixes #8607 - I've left out feature flags for rule linting because they're only parsed, not executed, which is where expressions are checked for disabled features. Discussions are still ongoing though.