Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error on NaN and Inf timestamps for OpenMetrics parser #9008

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Return error on NaN and Inf timestamps for OpenMetrics parser #9008

merged 1 commit into from
Jun 29, 2021

Conversation

cw9
Copy link
Contributor

@cw9 cw9 commented Jun 28, 2021

Currently OpenMetricsParser returns 0 as timestamp for NaN or Inf timestamps, this diff changes the behavior to return error on them instead

@cw9 cw9 changed the title Return error on NaN and Inf timestamps Return error on NaN and Inf timestamps for OpenMetrics parser Jun 28, 2021
@roidelapluie
Copy link
Member

Thanks for your PR. For legal reasons, we require that all commits are signed with a DCO before we can merge them. See this blog post for considerations around this.

This means that the last line of your commit message should read like:

Signed-Off-By: Your Name <your@email.address>

If you are using GitHub through the web interface, it's quickest to close this PR and open a new one with the appropriate line.

If you are using Git on the command line, it is probably quickest to amend and force push. You can do that with

git commit --amend --signoff
git push -f $remote $remote_branch_for_pr

As always, be careful when force-pushing.

@roidelapluie
Copy link
Member

Does this cover the timestamp in the examplars as well?

Signed-off-by: cw9 <chaow929@gmail.com>
@cw9
Copy link
Contributor Author

cw9 commented Jun 29, 2021

Does this cover the timestamp in the examplars as well?

Good point, added coverage for exemplar timestamp

Copy link
Member

@roidelapluie roidelapluie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roidelapluie roidelapluie merged commit 1a1394f into prometheus:main Jun 29, 2021
@roidelapluie roidelapluie mentioned this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants