Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsdb: coalesce lock/unlock operations for append #9061

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

bboreham
Copy link
Member

@bboreham bboreham commented Jul 6, 2021

Fetch the low watermark value under the same lock as we need for the appender, rather than releasing then re-aquiring a lock on the same Mutex.

Fixes #9059

Fetch the low watermark value under the same lock as we need for the
appender, rather than releasing then re-aquiring a lock on the same
Mutex.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@bboreham bboreham requested a review from codesome as a code owner July 6, 2021 17:24
@codesome codesome merged commit dc8f505 into prometheus:main Jul 7, 2021
@bboreham bboreham deleted the single-lock branch July 7, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coalesce write-lock and read-lock into one in tsdb
2 participants