Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compaction fails when total symbol size exceeds 2^32 bytes. #9104

Merged
merged 4 commits into from
Jul 20, 2021
Merged

Compaction fails when total symbol size exceeds 2^32 bytes. #9104

merged 4 commits into from
Jul 20, 2021

Conversation

t00350320
Copy link
Contributor

Compaction fails when total symbol size exceeds 2^32 bytes.

@t00350320 t00350320 requested a review from codesome as a code owner July 20, 2021 07:38
codesome
codesome approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@codesome codesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge on green

@t00350320
Compaction fails when total symbol size exceeds 2^32 bytes.
f681b8e 
Signed-off-by: tanghengjian <1040104807@qq.com>
@codesome
Copy link
Member

Please run go fmt on the file to fix the lint errors. And the earlier placement of the code was better, we should move it back to top of the function.

Compaction fails when total symbol size exceeds 2^32 bytes.
f0cf9fc 
Signed-off-by: root <tanghengjian@oppo.com>
@t00350320
Copy link
Contributor Author

Please run go fmt on the file to fix the lint errors. And the earlier placement of the code was better, we should move it back to top of the function.

with my Goland Jetbrains 2020.3, "reformat code" makes no difference. Nothing seems wrong or warning. Can you see the failed test case?

@codesome codesome merged commit 7337ecf into prometheus:main Jul 20, 2021
@codesome codesome mentioned this pull request Jul 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codesome codesome codesome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t00350320 @codesome