tsdb: use dennwc/varint to speed up WAL decoding #9106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny library, MIT-licensed, which unrolls the loop to go about twice as fast.
Needed to copy the unsigned-to-signed ("ZigZag") logic inline, previously provided by the
binary
package.Benchmarks ("before" is including the benchmark fixes from #8645, at commit 7816674f420bc5c7505bc1eb80b54939424851d2; "after" is cherry-picking the commit from this PR onto that.):
(there's no reason for allocs to change; just put that down to randomness in scheduling)
Looks like this should also speed up TSDB index, but I couldn't find any benchmarks relevant to that.
Timings of loading a real 5GB WAL: